-
Notifications
You must be signed in to change notification settings - Fork 617
refactor: hoist all devDeps to root #3032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: hoist all devDeps to root #3032
Conversation
4797803 to
723401a
Compare
723401a to
3056842
Compare
|
@trentm If Node 18 support is needed then there's more work to do. I missed this requirement when I started this work. 😕 How do you want to proceed? Try to roll back dependency versions until it's happy? ❯ npm ci
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: '@azure-rest/[email protected]',
npm warn EBADENGINE required: { node: '>=20.0.0' },
npm warn EBADENGINE current: { node: 'v18.20.8', npm: '10.8.2' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: '@azure/[email protected]',
npm warn EBADENGINE required: { node: '>=20.0.0' },
npm warn EBADENGINE current: { node: 'v18.20.8', npm: '10.8.2' }
npm warn EBADENGINE } |
3056842 to
804aa71
Compare
🤔 We say we support Active and Maintenance LTS versions of Node, and Node 18 is officially end of life. So it might be fine in Contrib to drop support for 18. That's a bigger discussion though (cc @open-telemetry/javascript-maintainers ) and we'll need to update docs too. |
@overbalance I don't think those EBADENGINE warnings are blocking for this PR. We already have a number of those warnings in the current state. Unfortunately an EBADENGINE warning will matter for some deps, but not for some deps that are just for testing. For example this one: That dep is used by tedious@17: which is a test dep. We intentionally install a recent-ish major version of |
46672a0 to
6ac6dbd
Compare
|
@trentm Those warnings are blocking CI from what I see. What do you recommend? |
I don't know what is going on. I can This CI step failed with a network error: https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/18537223726/job/53057847496?pr=3032 The other test jobs are stuck in The Ideas on what this could be:
|
99cc06d to
324495b
Compare
469663e to
9cb3aef
Compare
... because we are seeing hangs in `npm ci` on #3032.
9cb3aef to
2d57789
Compare
6c35007 to
6fce51c
Compare
6fce51c to
6e7f06f
Compare
|
@trentm I repaired the lockfile and this is finally 🟢. Thanks for your help. |
What this does
Hoists all build devDependencies to the root package.json.
Key changes
Test fixes
Dependencies
Configuration
Package-specific changes
@opentelemetry/instrumentation-socket.io
import * as expecttoimport expect(expect v29 uses default export)@opentelemetry/instrumentation-dns
@opentelemetry/instrumentation-aws-sdk
Browser packages (propagator-aws-xray, propagator-instana, instrumentation-user-interaction, instrumentation-long-task)