-
Notifications
You must be signed in to change notification settings - Fork 616
chore: improve test workflow and coverage reports #2866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve test workflow and coverage reports #2866
Conversation
…a/opentelemetry-js-contrib into dluna-ci-pr-speed-and-coverage
|
@pichlermarc thanks for the approval. If you don't mind to do another review. I had to change the codecov action but a custom script since there was no options in the action to update flags for each package and adding a codecov step for each package of the repo feels too much. Until now I've set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good % this comment here #2866 (comment)
@pichlermarc thanks for the review. I fixed it and if you give me the green check I'll remove the |
…a/opentelemetry-js-contrib into dluna-ci-pr-speed-and-coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you for working on this 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now - thanks for sorting out the problems with the path 🙂
I'll let you do the honors of merging this in 🙂
|
workflow run on main branch https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/17457685900 |
Which problem is this PR solving?
Changes the PR workflow to a single file to improve it making it faster with less resource consumption. The goal is to provide feedback to the PR author by compiling, testing and reporting coverage only for the affected packages in the PR (as for now it does a compilation, test, and coverage report for all in nodejs v18). More details on the plan can be found in #2870
Closes: #2870
Short description of the changes
*:ci:affectedscript at root to execute tasks only for affected packages (leveragingnxCLI)codecov.ymlto assign flags to each package so reports can be updated independentlyChecklist
Codecov flags feature require a first manual upload to create them so it would be helpful to resume #2214 to at least have a script at the root to testa and upload all reports. There is also some PRs that affect the flag configuration so it would be preferable to have them merged 1st
test:with-servicesscript at the root