- 
                Notifications
    
You must be signed in to change notification settings  - Fork 617
 
test(instrumentation-mongodb): Include all versions in coverage #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(instrumentation-mongodb): Include all versions in coverage #2681
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #2681      +/-   ##
==========================================
+ Coverage   90.96%   92.41%   +1.45%     
==========================================
  Files         171      171              
  Lines        8133     8133              
  Branches     1649     1649              
==========================================
+ Hits         7398     7516     +118     
+ Misses        735      617     -118      | 
    
| 
           This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.  | 
    
| "test": "npm run test-v3 && npm run test-v4 && npm run test-v5-v6 && nyc merge .nyc_output ./coverage/coverage-final.json", | ||
| "test-v3": "tav mongodb 3.7.4 npm run test-v3-run", | ||
| "test-v4": "tav mongodb 4.17.0 npm run test-v4-run", | ||
| "test-v5-v6": "tav mongodb 6.8.0 npm run test-v5-v6-run", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think is necessary to pin here the version? pacakge.json file already has the version fixed and if we want to update to a newer version we need to do it in both places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just double checked, for the pinned version, it's not needed. 👍
| 
           I have my doubts about this PR. IMHO the wider the support range is the more tests with different versions we would need to do in order to aim for high coverage. We may end up doing a subset of  I'll bring up this into today's SIG  | 
    
| 
           Thanks for the review @david-luna! The alternative I thought was generating coverage on   | 
    
          
 @onurtemizkan we discussed this approach for coverage in the SIG. We accept the tradeoff of running 3 different tests to get the coverage report. Also 
 Thanks for your contribution :) I'm going to approve, make sure your branch is up to date in order to be merged.  | 
    
| 
           @onurtemizkan sorry for the delay on this PR. I was checking if it's possible to have the coverage in TAV tests. Instead of stalling this PR I'll try it myself in another instrumentation.  | 
    
Which problem is this PR solving?
49.74%- LinkThis is because tests for MongoDB versions v3 and v4 are not included in the coverage report.
Short description of the changes
testcommand to make sure they are included in the coverage report