Skip to content

Conversation

@david-luna
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update @opentelemetry/semantic-conventions to ^1.22
  • Replace SemanticAttributes.* with exported strings SEMATTRS_*
  • Update README with new semantic convention package version and key

@codecov
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Merging #2115 (7d4aa8b) into main (dfb2dff) will decrease coverage by 0.32%.
Report is 59 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2115      +/-   ##
==========================================
- Coverage   90.97%   90.66%   -0.32%     
==========================================
  Files         146      147       +1     
  Lines        7492     7584      +92     
  Branches     1502     1517      +15     
==========================================
+ Hits         6816     6876      +60     
- Misses        676      708      +32     
Files Coverage Δ
...etry-instrumentation-mysql2/src/instrumentation.ts 94.73% <ø> (ø)
.../opentelemetry-instrumentation-mysql2/src/utils.ts 96.96% <100.00%> (ø)

... and 9 files with indirect coverage changes

@trentm trentm enabled auto-merge (squash) April 19, 2024 21:47
@trentm trentm merged commit 98fac09 into open-telemetry:main Apr 19, 2024
@david-luna david-luna deleted the dluna/mysql2-semconv-strings branch June 21, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants