feat(instrumentation-winston): Allow log level to be configured for log sending #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2016 +/- ##
==========================================
+ Coverage 90.97% 95.12% +4.14%
==========================================
Files 146 10 -136
Lines 7492 697 -6795
Branches 1502 142 -1360
==========================================
- Hits 6816 663 -6153
+ Misses 676 34 -642 |
trentm
reviewed
Mar 19, 2024
plugins/node/opentelemetry-instrumentation-winston/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
@trentm this one should be ready for another round, let me know if you have any feedback or concern |
trentm
approved these changes
Apr 17, 2024
Contributor
|
LGTM, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Related to #1919