[instrumentation-winston] LogRecord traceId and spanId values are not getting set correctly

[hectorhdzg]

Specific repro code provided by @trentm available here

This issue is related to auto generation of Logs when using Winston instrumentation
#1837

[trentm]

I started trying to see if I could find an easy fix for this, but I didn't get to one.

My next idea was to see if instrumentation-winston could automatically add a Winston formatter when a Logger is created. That formatter would add the current spanContext to the meta (or is it info) object using Symbols. Then both the "log correlation" and "log sending" could use that captured spanContext on the info object.

It would mean that "log sending" would depend on that formatter. So a user attempting to do log sending without instrumentation-winston would need to add two things to their logger config. Something like:

const logger = winston.createLogger({
  level: 'info',
  format: winston.format.combine(
    new OpenTelemetryCaptureSpanContextFormat(),
    // ... custom formatters if the user has any
  ),
  transports: [
    new winston.transports.Console(),
    new OpenTelemetryTransportV3()
  ]
});

This is just an idea, however. I haven't coded anything up to validate it.