feat(instrumentation-bunyan): Allow log level to be configured for log sending #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1919 +/- ##
==========================================
- Coverage 90.97% 90.88% -0.10%
==========================================
Files 146 143 -3
Lines 7492 7402 -90
Branches 1502 1480 -22
==========================================
- Hits 6816 6727 -89
+ Misses 676 675 -1
|
Contributor
|
Discussing on the issue: #1918 (comment) |
trentm
approved these changes
Feb 22, 2024
Contributor
trentm
left a comment
trentm
left a comment
There was a problem hiding this comment.
Looks good, just some nits.
plugins/node/opentelemetry-instrumentation-bunyan/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts
Outdated
Show resolved
Hide resolved
trentm
reviewed
Mar 9, 2024
plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #1918