Snippet Injection rollback and update test #8669
Closed
+71
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Jun 8, 2023
| jvmArgs("-XX:+IgnoreUnrecognizedVMOptions") | ||
| } | ||
| val testSnippetInjection by registering(Test::class) { | ||
| jvmArgs("-Dotel.experimental.javascript-snippet=<script> Test </script>") |
Contributor
There was a problem hiding this comment.
Running all tests twice, once without snippet injection and then with does not seem reasonable. Have you considered moving snippet tests to a separate class so they could be run independently or running the tests always with snippet injection enabled.
Contributor
Author
|
This pr needs further consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update for #7650.
Thanks @laurit for bringing up the test problem at #8390.
The reason for rolling back is that turning snippet into snippet supplier would cost ineffieiency in writing as get snippet would be called multiple times when injecting. (The snippet config is designed to be unchangeable during the OTEL running after user has set the value. )
In order to solve the test problem, the setting of snippet would be done at build.gradle instead of during the test.
Also, the unit test would be run twice, one with the snippet, and the other without the snippet.