JavaScript Snippet Injection Support Servlet 5 #8569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
May 25, 2023
...elemetry/javaagent/instrumentation/servlet/v5_0/snippet/SnippetInjectingResponseWrapper.java
Outdated
Show resolved
Hide resolved
trask
reviewed
May 25, 2023
instrumentation/servlet/servlet-5.0/javaagent/src/test/groovy/AbstractServlet5Test.groovy
Show resolved
Hide resolved
laurit
reviewed
May 26, 2023
instrumentation/servlet/servlet-5.0/javaagent/src/test/java/RequestDispatcherServlet.java
Show resolved
Hide resolved
laurit
reviewed
May 26, 2023
instrumentation/servlet/servlet-5.0/javaagent/src/test/java/RequestDispatcherServlet.java
Show resolved
Hide resolved
laurit
reviewed
May 26, 2023
...ntelemetry/javaagent/instrumentation/servlet/snippet/OutputStreamSnippetInjectionHelper.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/snippet/InjectionState.java
Show resolved
Hide resolved
.../javaagent/instrumentation/servlet/v5_0/snippet/Servlet5SnippetInjectingResponseWrapper.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
May 29, 2023
trask
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improvment for #7650
The file structure in Servlet5 folder is identical to that of Servlet 3.
Some identical files was moved to servlet/common folder for reduce redundency
The reponse wrapper files and servletOutPutStream write advice class could not be shared between servlet3 and servlet5 as the servlet3 is using javax.servlet.ServletOutputStream while servlet 5 is using jakarta.servlet.ServletOutputStream.