port 8080 was blocked #11375
Merged
port 8080 was blocked #11375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
trask
reviewed
May 16, 2024
Comment on lines
-26
to
+44
| assertClient(OtelSpringStarterSmokeTestController.REST_CLIENT); | ||
| testing.clearAllExportedData(); | ||
|
|
||
| RestClient client = restClientBuilder.baseUrl("http://localhost:" + port).build(); | ||
| assertThat( | ||
| client | ||
| .get() | ||
| .uri(OtelSpringStarterSmokeTestController.PING) | ||
| .retrieve() | ||
| .body(String.class)) | ||
| .isEqualTo("pong"); | ||
| assertClient(); |
Member
There was a problem hiding this comment.
I'm not sure the purpose of this test now since the RestClient telemetry is no longer captured or verified
Member
Author
There was a problem hiding this comment.
assertClient is doing the verification
Member
Author
There was a problem hiding this comment.
would it help to inline the method?
Member
There was a problem hiding this comment.
oh, sorry! I got confused b/c I was thinking of the other smoke test pattern where the test code itself doesn't get instrumented, only the app code, but realize that's not the case for these smoke tests
Comment on lines
175
to
+181
| void restTemplate() { | ||
| assertClient(OtelSpringStarterSmokeTestController.REST_TEMPLATE); | ||
| } | ||
|
|
||
| protected void assertClient(String url) { | ||
| testing.clearAllExportedData(); | ||
|
|
||
| testRestTemplate.getForObject(url, String.class); | ||
| RestTemplate restTemplate = restTemplateBuilder.rootUri("http://localhost:" + port).build(); | ||
| restTemplate.getForObject(OtelSpringStarterSmokeTestController.PING, String.class); | ||
| assertClient(); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port 8080 was blocked in all spring smoke tests - breaking parallel builds