Allow the Spring starter to configure the OTel Logback appender from system properties #10355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…system properties
Member
Author
|
If an attribute is configured both in the Logback XML file and with a system property, the system property overrides the configuration. |
zeitlinger
reviewed
Feb 1, 2024
...entation/spring/spring-boot-autoconfigure/src/testLogbackAppender/resources/logback-test.xml
Show resolved
Hide resolved
...emetry/instrumentation/spring/autoconfigure/instrumentation/logging/LogbackAppenderTest.java
Show resolved
Hide resolved
...ntation/spring/autoconfigure/instrumentation/logging/LogbackAppenderApplicationListener.java
Show resolved
Hide resolved
...-tests-otel-starter/src/test/java/io/opentelemetry/smoketest/OtelSpringStarterSmokeTest.java
Outdated
Show resolved
Hide resolved
zeitlinger
approved these changes
Feb 2, 2024
trask
reviewed
Feb 2, 2024
| @@ -0,0 +1,44 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
will this file conflict with the one we're autogenerating?
Member
Author
There was a problem hiding this comment.
No. See https://docs.spring.io/spring-boot/docs/current/reference/html/configuration-metadata.html#appendix.configuration-metadata.annotation-processor.adding-additional-metadata: "the annotation processor automatically merges items from META-INF/additional-spring-configuration-metadata.json into the main metadata file."
trask
reviewed
Feb 2, 2024
...ntation/spring/autoconfigure/instrumentation/logging/LogbackAppenderApplicationListener.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Feb 2, 2024
...emetry/instrumentation/spring/autoconfigure/instrumentation/logging/LogbackAppenderTest.java
Outdated
Show resolved
Hide resolved
7 tasks
steverao
pushed a commit
to steverao/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #10306, the OTel Logback appender is added by the OTel starter if the appender is not declared in a Logback XML file.
With this PR it becomes possible the configure the OpenTelemetry Logback appender with system properties from the Spring starter, as the OpenTelemetry Java agent is able to do.