Change Spring starter default otlp protocol from gRPC to http/protobuf #10212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @zeitlinger |
zeitlinger
approved these changes
Jan 11, 2024
Member
zeitlinger
left a comment
zeitlinger
left a comment
There was a problem hiding this comment.
LGTM - just small nitpick 😄
...a/io/opentelemetry/instrumentation/spring/autoconfigure/exporters/otlp/OtlpExporterUtil.java
Show resolved
Hide resolved
laurit
reviewed
Jan 11, 2024
| boolean isHttpProtobuf = Objects.equals(protocol, OtlpConfigUtil.PROTOCOL_HTTP_PROTOBUF); | ||
| boolean isHttpProtobuf = !"grpc".equals(protocol); | ||
|
|
||
| if (protocol != null |
Contributor
There was a problem hiding this comment.
sdk chooses to fail when invalid protocol is specified, see https://github.com/open-telemetry/opentelemetry-java/blob/d9f9812d4375a4229caff43bd681c50b7a45776a/exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/internal/OtlpLogRecordExporterProvider.java#L75
Member
Author
There was a problem hiding this comment.
Perhaps it could be rediscussed later with the perspective of what to do with the OTel starter configurations.
laurit
reviewed
Jan 11, 2024
| && !OtlpConfigUtil.PROTOCOL_HTTP_PROTOBUF.equals(protocol)) { | ||
| logger.warn( | ||
| protocol | ||
| + " protocol is not managed. " |
Contributor
There was a problem hiding this comment.
I'd rephrase this to something like Unknown OTLP protocol '{}', using 'http/protobuf' instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10206