Skip to content

Conversation

@pellared
Copy link
Member

Properly create a "Deprecated:" paragraph.

Before (https://pkg.go.dev/go.opentelemetry.io/otel/sdk/instrumentation#Library):

image

After:

image

image

@pellared pellared added documentation Provides helpful information pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jul 17, 2024
@pellared
Copy link
Member Author

Error: internal/otlptracetest/data.go:49:28: SA1019: instrumentation.Library is deprecated: use [Scope] instead. (staticcheck)
InstrumentationLibrary: instrumentation.Library{

Blocked (or simply conflicting) with #5627 (review)

@pellared pellared marked this pull request as draft July 17, 2024 14:10
@dmathieu
Copy link
Member

The commit in this PR is now cherry-picked into #5627.

@pellared pellared closed this Jul 17, 2024
@pellared pellared deleted the deprecate-fix branch May 20, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Provides helpful information pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants