Skip to content

endpoint parsing exporter fixes and small cleanup in tracer #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 22, 2021

Conversation

tsloughter
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #212 (a2fecab) into main (4b38bb4) will increase coverage by 0.29%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   35.25%   35.55%   +0.29%     
==========================================
  Files          64       64              
  Lines        3341     3350       +9     
==========================================
+ Hits         1178     1191      +13     
+ Misses       2163     2159       -4     
Flag Coverage Δ
api 51.61% <ø> (ø)
elixir 14.03% <ø> (ø)
erlang 35.63% <88.23%> (+0.33%) ⬆️
exporter 19.06% <87.50%> (+0.48%) ⬆️
sdk 71.69% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/opentelemetry_api/src/otel_ctx.erl 79.16% <ø> (ø)
...ntelemetry_exporter/src/opentelemetry_exporter.erl 77.87% <87.50%> (+4.79%) ⬆️
apps/opentelemetry/src/otel_tracer_default.erl 100.00% <100.00%> (ø)
apps/opentelemetry/src/otel_metric_accumulator.erl 79.16% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b38bb4...3db36a3. Read the comment docs.

@tsloughter tsloughter merged commit b4c2df5 into open-telemetry:main Feb 22, 2021
@tsloughter tsloughter deleted the api-cleanup branch February 22, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants