Skip to content

Conversation

@rajkumar-rangaraj
Copy link
Member

@rajkumar-rangaraj rajkumar-rangaraj commented Jan 24, 2025

Fixes #6083 (comment)
Design discussion issue #

Changes

Please provide a brief description of the changes here.

  • Modified the incorrect status value set in ExportClientGrpcResponse.
  • Existing bug does not impact the telemetry data to be exported. This could be part of next release.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes

…ccess export response was incorrectly marked
@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner January 24, 2025 00:26
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Jan 24, 2025
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 2828321 into open-telemetry:main Jan 24, 2025
35 checks passed
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (db828ce) to head (8ae86e4).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6099   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files         257      257           
  Lines       11650    11650           
=======================================
  Hits        10065    10065           
  Misses       1585     1585           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants