-
Couldn't load subscription status.
- Fork 849
[repo] Updates for .NET 9 release #5967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Updates for .NET 9 release #5967
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5967 +/- ##
==========================================
+ Coverage 83.38% 86.85% +3.47%
==========================================
Files 297 263 -34
Lines 12531 12006 -525
==========================================
- Hits 10449 10428 -21
+ Misses 2082 1578 -504
Flags with carried forward coverage won't be shown. Click here to find out more. |
| * Updated `Microsoft.Extensions.Hosting.Abstractions` package | ||
| version to `9.0.0-rc.1.24431.7`. | ||
| ([#5853](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5853)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajkumar-rangaraj This was added here: https://github.com/open-telemetry/opentelemetry-dotnet/pull/5853/files#diff-1788690fb9e80d48d96d92320b51dc391560eb447490867db722279f47939d1eR25-R27
But OTLP doesn't have a dependency on Microsoft.Extensions.Hosting.Abstractions. Seems like a copy/paste issue? I just went ahead and removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This has been a breaking change for us and should not have been on a minor version change according to SemVer2. We rely on 8.x versions of those to ensure we are not breaking upstream customers and this force-updates our dependencies transitively. So please try to avoid those changes without changing the major version in the future. This also leads to our tooling always suggesting a major-bound update for this library that will break the toolchain, so we have to manually suppress it. |
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes