- 
                Notifications
    You must be signed in to change notification settings 
- Fork 849
[api-baggage] revert space encoding change #5687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-baggage] revert space encoding change #5687
Conversation
|  | ||
| ## Unreleased | ||
|  | ||
| * **Breaking change:** Revert space character encoding change from `+` to `%20` | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this PR # as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in e474fa7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more information about why we're reverting this change to the changelog or PR description. Something to the effect of "... because the fix did not properly address the inconsistency with the baggage spec. We will address this issue more completely in a later release"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description updated.
| Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #5687      +/-   ##
==========================================
+ Coverage   83.38%   85.99%   +2.61%     
==========================================
  Files         297      254      -43     
  Lines       12531    11054    -1477     
==========================================
- Hits        10449     9506     -943     
+ Misses       2082     1548     -534     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we circle back to fixing this again, we should start with a solid test suite and vet it across other language implementations. Without a well-vetted test suite it is difficult to review and be confident in these fixes because most people do not have the depth of familiarity required of the baggage specification.
Changes
Revert changes from #5303 because
Uri.UnescapeDataStringdoesn't replace percent-encoded octet sequences that do not match the UTF-8 encoding scheme with the replacement code point (U+FFFD). This is required by the W3C Baggage spec.The plan is to address all of the issues related to baggage propagation with the later release.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes