- 
                Notifications
    You must be signed in to change notification settings 
- Fork 849
[sdk-metrics] Expose ExemplarReservoir and support configuration via views #5542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk-metrics] Expose ExemplarReservoir and support configuration via views #5542
Conversation
| Is Exemplar stable release planned for 1.9.0 ? if yes, can we just expose this unconditionally? Or are you anticipating that 1.9.0 stable won't have stable exemplars, and hence this PR? | 
| Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #5542      +/-   ##
==========================================
+ Coverage   83.38%   85.56%   +2.18%     
==========================================
  Files         297      289       -8     
  Lines       12531    12484      -47     
==========================================
+ Hits        10449    10682     +233     
+ Misses       2082     1802     -280     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 | 
| 
 Yes it is planned for 1.9.0. I don't think we're ready to remove experimental status yet though. I want to finish implementing the spec and wait for it go stable before we do that. Probably just a final PR at the end of the effort which makes the switch for everything. | 
Changes
ExemplarReservoirin pre-release builds.MetricStreamConfiguration.ExemplarReservoirFactoryin pre-release builds.Details
This is being done to be complaint with the view configuration spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#stream-configuration
Note: At the moment everything on
Exemplarhas aprivatesetter and the Update method isinternalso there isn't really a good practical way to make a customExemplarReservoir. I'm going to tackle that as a follow-up because there are different approaches we could take.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes