Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Mar 26, 2024

Changes

Use new attributes to propagate scope according to https://github.com/open-telemetry/opentelemetry-specification/blob/v1.31.0/specification/common/mapping-to-non-otlp.md#instrumentationscope

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team March 26, 2024 07:16
@codecov
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.42%. Comparing base (6250307) to head (fbd29b2).
Report is 142 commits behind head on main.

❗ Current head fbd29b2 differs from pull request most recent head f9523f5. Consider uploading reports for the commit f9523f5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5473      +/-   ##
==========================================
+ Coverage   83.38%   85.42%   +2.04%     
==========================================
  Files         297      289       -8     
  Lines       12531    12511      -20     
==========================================
+ Hits        10449    10688     +239     
+ Misses       2082     1823     -259     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.42% <50.00%> (?)
unittests-Solution-Stable 85.39% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...plementation/ZipkinActivityConversionExtensions.cs 95.79% <50.00%> (-0.79%) ⬇️

... and 61 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Vishwesh Bankwar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants