- 
                Notifications
    
You must be signed in to change notification settings  - Fork 849
 
[otlp] Add experimental feature flag for enabling retries #5435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Add experimental feature flag for enabling retries #5435
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #5435      +/-   ##
==========================================
+ Coverage   83.38%   84.87%   +1.48%     
==========================================
  Files         297      284      -13     
  Lines       12531    12224     -307     
==========================================
- Hits        10449    10375      -74     
+ Misses       2082     1849     -233     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
        
          
                src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptionsExtensions.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ExperimentalOptions.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ExperimentalOptions.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ExperimentalOptions.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptionsExtensions.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpMetricExporterExtensions.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/add-experimental-option-for-retry
        
          
                src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ExperimentalOptions.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ExperimentalOptions.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a CHANGELOG update.
Towards #1779
Design discussion issue #
Changes
Adds
OTEL_DOTNET_EXPERIMENTAL_OTLP_ENABLE_INMEMORY_RETRYto enable retries in case of transient errors.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes