- 
                Notifications
    You must be signed in to change notification settings 
- Fork 849
[otlp] Use LogRecord.Logger.Name for instrumentation scope if LogRecord.CategoryName is null #5300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
        
          
                src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpLogRecordTransformer.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpLogRecordTransformer.cs
          
            Show resolved
            Hide resolved
        
      | @AB027PS This is good thanks! There are a few things we need to do before we can merge: 
 If you need help with anything let me know, happy to assist. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #5274
Changes
I made a change to OtlpLogRecordTransformer to address a situation where LogRecord.CategoryName is null
according to a suggestion in #5274
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes