- 
                Notifications
    
You must be signed in to change notification settings  - Fork 849
 
[logging] UseOpenTelemetry extension & WithLogging default behavior #5072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            utpilla
  merged 9 commits into
  open-telemetry:main
from
CodeBlanch:hosting-withlogging-defaultbehavior
  
      
      
   
  Nov 29, 2023 
      
    
                
     Merged
            
            [logging] UseOpenTelemetry extension & WithLogging default behavior #5072
                    utpilla
  merged 9 commits into
  open-telemetry:main
from
CodeBlanch:hosting-withlogging-defaultbehavior
  
      
      
   
  Nov 29, 2023 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          Codecov Report
 
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #5072      +/-   ##
==========================================
+ Coverage   83.02%   83.31%   +0.28%     
==========================================
  Files         296      296              
  Lines       12315    12320       +5     
==========================================
+ Hits        10225    10264      +39     
+ Misses       2090     2056      -34     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
  | 
    
              
                    utpilla
  
              
              reviewed
              
                  
                    Nov 29, 2023 
                  
              
              
            
            
              
                    utpilla
  
              
              reviewed
              
                  
                    Nov 29, 2023 
                  
              
              
            
            
              
                    utpilla
  
              
              approved these changes
              
                  
                    Nov 29, 2023 
                  
              
              
            
            
              
                    utpilla
  
              
              reviewed
              
                  
                    Nov 29, 2023 
                  
              
              
            
            
              
                    utpilla
  
              
              approved these changes
              
                  
                    Nov 29, 2023 
                  
              
              
            
            
              
                    alanwest
  
              
              approved these changes
              
                  
                    Nov 29, 2023 
                  
              
              
            
            
  This was referenced Nov 29, 2023 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    pkg:OpenTelemetry.Extensions.Hosting
  Issues related to OpenTelemetry.Extensions.Hosting NuGet package 
  
    pkg:OpenTelemetry
  Issues related to OpenTelemetry NuGet package 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Follow-up to #4958
Fixes #4985
Relates to #4433
Changes
ILoggingBuilder.UseOpenTelemetryexperimental APIs. This brings full parity w.r.t.IServiceCollection/IServiceProviderthat we have with metrics & tracing to logging.OpenTelemetryBuilder.WithLoggingexperimental API to automatically register theILoggerProviderintegration. This mirrors whatWithMetricsdoes (forIMetricsListenerintegration).Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes