Skip to content

[console-exporter] Add extension on LoggerProviderBuilder #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2023
Merged

[console-exporter] Add extension on LoggerProviderBuilder #4549

merged 2 commits into from
Jun 6, 2023

Conversation

@CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Jun 6, 2023

Relates to #4433

Changes

  • Adds an extension for registering ConsoleExporter against a LoggerProviderBuilder instance

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team June 6, 2023 16:42
@CodeBlanch CodeBlanch mentioned this pull request Jun 6, 2023
Open
53 tasks
@codecov
Copy link

codecov bot commented Jun 6, 2023 •
edited
Loading

Codecov Report

Merging #4549 (394f12f) into main (a457558) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4549      +/-   ##
==========================================
- Coverage   85.54%   85.41%   -0.13%     
==========================================
  Files         320      320              
  Lines       12628    12640      +12     
==========================================
- Hits        10802    10796       -6     
- Misses       1826     1844      +18
Impacted Files Coverage Δ
...porter.Console/ConsoleExporterLoggingExtensions.cs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@utpilla utpilla merged commit e74e0ed into open-telemetry:main Jun 6, 2023
@CodeBlanch CodeBlanch deleted the consoleexporter-loggerproviderbuilder-extension branch June 6, 2023 23:15
mfogliatto pushed a commit to mfogliatto/opentelemetry-dotnet that referenced this pull request Jun 10, 2023
@CodeBlanch @mfogliatto
[console-exporter] Add extension on LoggerProviderBuilder (open-telem…
e9aa002 
…etry#4549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@utpilla utpilla utpilla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CodeBlanch @vishweshbankwar @utpilla