-
Notifications
You must be signed in to change notification settings - Fork 849
[sdk-logs] Add Sdk.CreateLoggerProviderBuilder #4464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ | |
| using System.Diagnostics; | ||
| using OpenTelemetry.Context.Propagation; | ||
| using OpenTelemetry.Internal; | ||
| using OpenTelemetry.Logs; | ||
| using OpenTelemetry.Metrics; | ||
| using OpenTelemetry.Trace; | ||
|
|
||
|
|
@@ -83,5 +84,19 @@ public static TracerProviderBuilder CreateTracerProviderBuilder() | |
| { | ||
| return new TracerProviderBuilderBase(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Creates a <see cref="LoggerProviderBuilder"/> which is used to build | ||
| /// an <see cref="LoggerProvider"/>. In a typical application, a single | ||
| /// <see cref="LoggerProvider"/> is created at application startup and | ||
| /// disposed at application shutdown. It is important to ensure that the | ||
| /// provider is not disposed too early. | ||
| /// </summary> | ||
| /// <returns><see cref="LoggerProviderBuilder"/> instance, which is used | ||
| /// to build a <see cref="LoggerProvider"/>.</returns> | ||
| internal static LoggerProviderBuilder CreateLoggerProviderBuilder() | ||
| { | ||
| return new LoggerProviderServiceCollectionBuilder(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we rename There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can, but I would prefer not to. Here is the reasoning... If you look at the 1.3.1 branch, hosting used to have two classes TracerProviderBuilderHosting and MeterProviderBuilderHosting. Those used the Things changed in 1.4 and we no longer use inheritance to make this stuff work. The new So we could rename it |
||
| } | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.