Skip to content

[di-logs] Add internal artifacts for OTel spec log bridge API #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2023
Merged

[di-logs] Add internal artifacts for OTel spec log bridge API #4434

merged 1 commit into from
Apr 25, 2023

Conversation

@CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Apr 25, 2023 •
edited
Loading

Relates to #4433

Changes

  • Adds internal artifacts to OpenTelemetry.Api.ProviderBuilderExtensions for implementing the Logs Bridge API from spec (now stable but we'll keep everything internal for now)

[Reminder: OpenTelemetry.Api.ProviderBuilderExtensions contains the dependency injection surface for the builders.]

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch requested a review from a team April 25, 2023 17:24
@CodeBlanch CodeBlanch mentioned this pull request Apr 25, 2023
Open
53 tasks
@CodeBlanch CodeBlanch merged commit 7cec101 into open-telemetry:main Apr 25, 2023
@CodeBlanch CodeBlanch deleted the log-api-extensions branch April 25, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanwest alanwest alanwest approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CodeBlanch @alanwest