Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Nov 13, 2025

Changes

[EFCore/Process/Quartz] Add .NET8 and .NET10 TFM

Needed by auto-instrumentation. It allows to target lower version of transitive packages. .NET Standard brings always the latest (10.0.0).

There is a chance, that we will need to make similar changes for other packages when requested.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz labels Nov 13, 2025
@Kielek Kielek marked this pull request as ready for review November 13, 2025 13:41
@Kielek Kielek requested a review from a team as a code owner November 13, 2025 13:41
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.88%. Comparing base (77c34c8) to head (917e82b).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3519   +/-   ##
=======================================
  Coverage   70.88%   70.88%           
=======================================
  Files         430      430           
  Lines       17214    17214           
=======================================
  Hits        12202    12202           
  Misses       5012     5012           
Flag Coverage Δ
unittests-Instrumentation.EntityFrameworkCore 80.80% <100.00%> (ø)
unittests-Instrumentation.Process 100.00% <100.00%> (ø)
unittests-Instrumentation.Quartz 78.76% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mplementation/EntityFrameworkDiagnosticListener.cs 85.18% <100.00%> (ø)
...elemetry.Instrumentation.Process/ProcessMetrics.cs 100.00% <100.00%> (ø)
....Quartz/Implementation/QuartzDiagnosticListener.cs 82.60% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kielek Kielek enabled auto-merge November 13, 2025 13:43
@Kielek Kielek added this pull request to the merge queue Nov 13, 2025
Merged via the queue into open-telemetry:main with commit 6a43b08 Nov 13, 2025
79 checks passed
@Kielek Kielek deleted the add-tfm branch November 13, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants