- 
                Notifications
    You must be signed in to change notification settings 
- Fork 356
[Instrumentation.WCF] AspNetParentSpanCorrector fixes #3248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …oolean to prevent potential race conditions in the method
…y the AspNet instrumentation It allows to call instrumentation packages in any order
…P.NET instrumentation
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##             main    #3248   +/-   ##
=======================================
  Coverage   70.09%   70.09%           
=======================================
  Files         430      430           
  Lines       16941    16946    +5     
=======================================
+ Hits        11874    11879    +5     
  Misses       5067     5067           
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 🚀 New features to boost your workflow:
 | 
              
                    martincostello
  
              
              approved these changes
              
                  
                    Oct 20, 2025 
                  
              
              
            
            
      
        
      
      
  
    3 tasks
  
  This was referenced Oct 22, 2025 
      
  This was referenced Oct 29, 2025 
      
      
     Merged
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Follow up to #3151
Changes
While reviewing consider checking each commit independently. Fixes 3 issues, the one related to recursion is critical.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)