Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Oct 20, 2025

Follow up to #3151

Changes

While reviewing consider checking each commit independently. Fixes 3 issues, the one related to recursion is critical.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

…oolean

to prevent potential race conditions in the method
…y the AspNet instrumentation

It allows to call instrumentation packages in any order
@github-actions github-actions bot added the comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf label Oct 20, 2025
@Kielek Kielek changed the title [Instrumentation.WCF] [Instrumentation.WCF] AspNetParentSpanCorrector fixes Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.09%. Comparing base (8b5340d) to head (48b815f).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3248   +/-   ##
=======================================
  Coverage   70.09%   70.09%           
=======================================
  Files         430      430           
  Lines       16941    16946    +5     
=======================================
+ Hits        11874    11879    +5     
  Misses       5067     5067           
Flag Coverage Δ
unittests-Instrumentation.Wcf 79.68% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...on.Wcf/Implementation/AspNetParentSpanCorrector.cs 95.23% <100.00%> (+0.30%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kielek Kielek marked this pull request as ready for review October 20, 2025 11:33
@Kielek Kielek requested a review from a team as a code owner October 20, 2025 11:33
@Kielek Kielek merged commit 5d610ac into open-telemetry:main Oct 20, 2025
65 checks passed
@Kielek Kielek deleted the wcf-fixes branch October 20, 2025 12:03
This was referenced Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants