- 
                Notifications
    You must be signed in to change notification settings 
- Fork 356
[SqlClient] Rename Enrich property #3080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##             main    #3080   +/-   ##
=======================================
  Coverage   70.04%   70.04%           
=======================================
  Files         429      429           
  Lines       16838    16838           
=======================================
  Hits        11794    11794           
  Misses       5044     5044           
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 🚀 New features to boost your workflow:
 | 
3abc4e5    to
    a07878a      
    Compare
  
    a07878a    to
    a8e6c9f      
    Compare
  
    a8e6c9f    to
    49c0494      
    Compare
  
    f491275    to
    9b04ebd      
    Compare
  
    9b04ebd    to
    e47ccf5      
    Compare
  
    | This PR was marked stale due to lack of activity. It will be closed in 7 days. | 
| Depends on #3079 | 
| This PR was marked stale due to lack of activity. It will be closed in 7 days. | 
Remove members from the public API that no nothing on .NET Framework.
Fix-up defines so that redundant code isn't included for .NET Framework.
Generated by `dotnet pack --configuration Release /p:ApiCompatGenerateSuppressionFile=true -p:EnablePackageValidation=true`.
4 spaces, not 2.
Remove members from the public API that no nothing on .NET Framework.
Fix-up defines so that redundant code isn't included for .NET Framework.
Remove members from the public API that no nothing on .NET Framework.
Renames the `Enrich` property to `EnrichWithSqlCommand` and removes the custom event name parameter.
Update signatures in `CompatibilitySuppressions.xml`.
Fixes #3074
Changes
Renames the
Enrichproperty toEnrichWithSqlCommandand removes the custom event name parameter.The parameter remains an
objectso it is compatible with bothSystem.Data.SqlClientandMicrosoft.Data.SqlClient.Builds on top of #3079.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes