Skip to content

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Sep 8, 2025

Fixes #3074

Changes

Renames the Enrich property to EnrichWithSqlCommand and removes the custom event name parameter.

The parameter remains an object so it is compatible with both System.Data.SqlClient and Microsoft.Data.SqlClient.

Builds on top of #3079.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient labels Sep 8, 2025
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.04%. Comparing base (8409e20) to head (b0699d3).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3080   +/-   ##
=======================================
  Coverage   70.04%   70.04%           
=======================================
  Files         429      429           
  Lines       16838    16838           
=======================================
  Hits        11794    11794           
  Misses       5044     5044           
Flag Coverage Δ
unittests-Instrumentation.SqlClient 87.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ient/Implementation/SqlClientDiagnosticListener.cs 88.31% <100.00%> (ø)
....SqlClient/SqlClientTraceInstrumentationOptions.cs 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 17, 2025
@Kielek Kielek removed the Stale label Sep 17, 2025
@martincostello
Copy link
Member Author

Depends on #3079

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 25, 2025
@Kielek Kielek removed the Stale label Sep 25, 2025
Remove members from the public API that no nothing on .NET Framework.
Fix-up defines so that redundant code isn't included for .NET Framework.
Generated by `dotnet pack --configuration Release /p:ApiCompatGenerateSuppressionFile=true -p:EnablePackageValidation=true`.
Remove members from the public API that no nothing on .NET Framework.
Fix-up defines so that redundant code isn't included for .NET Framework.
Remove members from the public API that no nothing on .NET Framework.
Renames the `Enrich` property to `EnrichWithSqlCommand` and removes the custom event name parameter.
Update signatures in `CompatibilitySuppressions.xml`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename SqlClientTraceInstrumentationOptions.Enrich

2 participants