Skip to content

Set initial AWS Semantic Convention list capacity to guard against list resizing #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025
Merged

Set initial AWS Semantic Convention list capacity to guard against list resizing #2653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
855039e
set initial list capacity to guard against list resizing
ppittle Mar 10, 2025
2eed17a
add changlelog
ppittle Mar 10, 2025
0b1bab7
fix code warnings
ppittle Mar 10, 2025
c5f5bca
Merge branch 'main' into aws-harden-semantic-conventions-list
Kielek Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.AWS/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Set itinital capacity for AWS Semantic Convention Attribute Builder
([#2653](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2653))

## 1.11.1

Released 2025-Mar-05
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Set itinital capacity for AWS Semantic Convention Attribute Builder
([#2653](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2653))

## 1.11.1

Released 2025-Mar-05
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Resources.AWS/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Set itinital capacity for AWS Semantic Convention Attribute Builder
([#2653](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2653))

## 1.11.1

Released 2025-Mar-05
Expand Down
6 changes: 5 additions & 1 deletion src/Shared/AWS/AWSSemanticConventions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,11 @@ public ParameterMappingBuilderImpl AddAttributeAWSBedrockKnowledgeBaseId(string
public class AttributeBuilderImpl
{
private readonly AWSSemanticConventions awsSemanticConventions;
private List<KeyValuePair<string, object>> state = [];
private List<KeyValuePair<string, object>> state = new(

// set initial capacity to prevent array resizing
// and prevent #2652 - possible race condition when running from unit tests
capacity: 16);

public AttributeBuilderImpl(AWSSemanticConventions semanticConventions)
{
Expand Down
Loading