Skip to content

Conversation

@abuhsayem
Copy link
Contributor

@abuhsayem abuhsayem commented Jan 29, 2025

[Original PR #2232 created by Sagar who is on bonding leave]

Changes

  • Allow underscore in event name

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@abuhsayem abuhsayem requested a review from a team as a code owner January 29, 2025 19:00
@github-actions github-actions bot requested a review from CodeBlanch January 29, 2025 19:01
@github-actions github-actions bot added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Jan 29, 2025
@CodeBlanch CodeBlanch changed the title Allow underscore in event name by Sagar Vishwakarma [OneCollector] Allow underscore in event name Jan 29, 2025
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit dc4b3e4 into open-telemetry:main Jan 29, 2025
65 checks passed
@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (71655ce) to head (b4bde83).
Report is 714 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #2529       +/-   ##
==========================================
- Coverage   73.91%       0   -73.92%     
==========================================
  Files         267       0      -267     
  Lines        9615       0     -9615     
==========================================
- Hits         7107       0     -7107     
+ Misses       2508       0     -2508     

see 263 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants