Skip to content

Conversation

@Dreamescaper
Copy link
Contributor

Fixes #2445

Changes

Handle the case is InvokedFunctionArn is null in LambdaContext.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@Dreamescaper Dreamescaper requested a review from a team as a code owner January 7, 2025 11:52
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Dreamescaper / name: Oleksandr Liakhevych (eeb9ec2, e6127a6)
  • ✅ login: Kielek / name: Piotr Kiełkowicz (6ae5f32)

@github-actions github-actions bot added the comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda label Jan 7, 2025
@Dreamescaper Dreamescaper force-pushed the do_not_crash_on_empty_lambda_context branch from ab4e681 to bf7baf2 Compare January 7, 2025 11:54
@Dreamescaper Dreamescaper force-pushed the do_not_crash_on_empty_lambda_context branch from bf7baf2 to eeb9ec2 Compare January 7, 2025 11:57
@Kielek
Copy link
Member

Kielek commented Jan 7, 2025

Consider adding CHANGELOG entry.

@Dreamescaper
Copy link
Contributor Author

@Kielek
Updated.

@ppittle
Copy link
Member

ppittle commented Jan 7, 2025

@Dreamescaper - thank you for contributing the fix!

Copy link
Member

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging based on @ppittle comment.

@Kielek Kielek merged commit fbba3f8 into open-telemetry:main Jan 8, 2025
61 checks passed
@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (71655ce) to head (6ae5f32).
Report is 677 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #2457       +/-   ##
==========================================
- Coverage   73.91%       0   -73.92%     
==========================================
  Files         267       0      -267     
  Lines        9615       0     -9615     
==========================================
- Hits         7107       0     -7107     
+ Misses       2508       0     -2508     

see 263 files with indirect coverage changes

@martincostello
Copy link
Member

I just ran into this myself trying to update the package - is it possible to get a new version with this change released to NuGet?

@Kielek
Copy link
Member

Kielek commented Jan 14, 2025

@martincostello
Copy link
Member

#2461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Lambda integration fails if no InvokedFunctionArn present

6 participants