-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add UserActionInstrumentation #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add UserActionInstrumentation #35
Conversation
fb3b29e to
e888059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an existing web-common package. It might be confusing to have two similar packages published in npm. I suggest that we either move web-common to this repo, or add these utils there for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least in my mind this package is just internal tooling shared across instrumentations, I don't think it should be published. Same as the test utils package
f24c1cc to
918ad5f
Compare
Co-authored-by: Benoît <[email protected]>
5af2852 to
f8335af
Compare
Goal
Add the first iteration of the user action instrumentation only covering the mousedown event based on the current semantic conventions PR
Extras
Vitest
Simple vitest setup for running unit tests using jsdom
Initial monorepo setup
Preparing for a future turbopack integration, I set up some packages for the upcoming monorepo setup.
Each package has these set of scripts:
Once we set up a monorepo tool (possible turbopack) we can easily run these commands from root
TODO: make sure package can build
What's not included