osc/rdma: fix amo-based accumulate #8469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue in osc/rdma when AMOs are used for accumulate operations (vs get-accumulate). In this case a temporary buffer is needed to hold the result of the operation (since fetching atomics are used). This buffer was 1) zero-sized, and 2) not freed. Both of these issues are fixed in this commit. There was also an issue with unpacking due to using an uninitialized convertor. The convertor is no longer passed in when no result is required. Signed-off-by: Nathan Hjelm <[email protected]>
|
These fixes were lost in the rebases of #6301. |
awlauria
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in osc/rdma when AMOs are used for accumulate operations
(vs get-accumulate). In this case a temporary buffer is needed to hold the
result of the operation (since fetching atomics are used). This buffer was
commit. There was also an issue with unpacking due to using an uninitialized
convertor. The convertor is no longer passed in when no result is required.
Signed-off-by: Nathan Hjelm [email protected]