ompi/datatype: Fix predefined datatype initialization/finalization #8415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@bosilca Could you review? |
bosilca
reviewed
Feb 1, 2021
Member
|
sorry @kawashima-fj I reviewed this last week but I forgot to press submit. |
There were three bugs. - `ompi_datatype_number_of_predefined_data` was one less because it tracked the last f2c index number which starts with zero. (`ompi_datatype_number_of_predefined_data` is used in the `ompi_datatype_match_size` function and it expects the number, not the index.) - Two `for` loops did not visit `ompi_mpi_count` because the comparison is `<` for the index, not `<=`. - Two `for` loops did not visit four datatypes which were added after `ompi_mpi_count`. And, allow us to add the datatypes not in the monotonically increasing order. Signed-off-by: KAWASHIMA Takahiro <[email protected]>
kawashima-fj
force-pushed
the
fix-predef-dt-init-fini
branch
from
d074ce0 to
9f1d313
Compare
Member
|
bot:ibm:retest |
Member
Author
|
I run some datatype tests and had no problems. @bosilca Thanks for your review. Could you approve if you are happy with this change? The PR is still blocked. |
bosilca
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three bugs in the source code.
ompi_datatype_number_of_predefined_datawas one less becauseit tracked the last f2c index number which starts with zero.
(
ompi_datatype_number_of_predefined_datais used in theompi_datatype_match_sizefunction and it expects the number,not the index.)
forloops did not visitompi_mpi_countbecause thecomparison is
<for the index, not<=.forloops did not visit four datatypes which were addedafter
ompi_mpi_count.I don't know whether these are real (user-observable) bugs.