[Fix] editable install in python>=3.13
#1673
Open
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sub-PR of #1665.
This PR fixes a compatibility issue in
get_version()caused by relying onexec()to modify the local namespace.The current implementation executes a version file with
exec(...)and then attempts to retrieve__version__fromlocals(). While this may appear to work inPython ≤3.12, it breaks inPython 3.13+due to changes introduced by PEP 667, which standardizes execution context behavior and preventsexec()from mutating a function’s local scope.To ensure correctness and forward compatibility, this PR explicitly passes a dedicated dictionary as the global namespace to
exec(), and safely reads__version__from that namespace.Noted that
setup.pyis deprecated and we should includepyproject.tomlaccording to the latest PyPA, and PEP 621.