Rendering image attachments from discussions in main view causes performance issues.

[dmitriim]

on behalf of @yao9394

Even users could not see the image attachments from main since its hidden by css. But the image attachments are still being returned in html. This is going to download all image attachments from discussions. If most of discussions have an image attachment, this will trigger many requests to retrieve and down images. This would cause performance issue.

[dmitriim]

@yao9394 hey!
Can you update this one with the steps to replicate? And maybe screenshots?

[aspark21]

Hi @dmitriim ,

We've just run into that, the mod/hsuforum/view.php is downloading 400MB+ of images when loading the forum index. But the only images that are displayed are the thumbnails of people's profile pictures so it didn't make sense why so many image files were being loaded up.

Relatively well used activity with 108 discussions and with embedded images in most of the posts.

To observe this, just open a window, open the chrome dev tools & go to network tab, go to Moodle & login, got to the forum mod/hsuforum/view.php

You see no images but profile pics. Wait for all of the files to load.

This was causing extra strain too because all of the file downloads end up holding the session lock making navigating around the forum even more painfully slow / timing out.

[aspark21]

Moodle: 3.9.10
Hsuforum: MOODLE_39_STABLE latest

[aspark21]

@dmitriim sorry didn't realise you were submitting the fix for this - https://github.com/open-lms-open-source/moodle-mod_hsuforum/pull/20/files

Open LMS Team any reason why you still haven't merged this?
@fabianbatioja @dvdcastro

[aspark21]

Or @mr-www-admin ?

[aspark21]

Hello?

the current fix now has a merge conflict with 4.x version.

@danielcifuentesopen

is it worth us getting it rebased on master or you going to look at this internally? or do you just not care at all?