-
Notifications
You must be signed in to change notification settings - Fork 82
🐛 fix: ManifestWorkReplicaSet applied capitalization error #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: ManifestWorkReplicaSet applied capitalization error #399
Conversation
Signed-off-by: Mike Ng <[email protected]>
/assign @qiujian16 |
WalkthroughRenames the summary field key from Applied to applied in the ManifestWorkReplicaSet CRD schema and aligns the Go struct’s JSON tag accordingly. No type changes or logic modifications are introduced. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
work/v1alpha1/types_manifestworkreplicaset.go (1)
135-135
: Approve JSON tag change; update docs and schemas
The JSON tag change toapplied
follows Kubernetes conventions and no references to the oldApplied
tag remain. This is a breaking change—update CRD schemas, examples, and user documentation to reflect the new field name.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
work/v1alpha1/0000_00_work.open-cluster-management.io_manifestworkreplicasets.crd.yaml
(2 hunks)work/v1alpha1/types_manifestworkreplicaset.go
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: verify
🔇 Additional comments (1)
work/v1alpha1/0000_00_work.open-cluster-management.io_manifestworkreplicasets.crd.yaml (1)
744-744
: LGTM! Both occurrences updated consistently.The CRD schema correctly renames the field from
Applied
toapplied
in both locations:
- Line 744:
status.placementSummary[].summary.applied
- Line 766:
status.summary.applied
The field descriptions are preserved appropriately, and the changes align with the Go struct JSON tag update in
types_manifestworkreplicaset.go
.Also applies to: 766-766
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
87a44af
into
open-cluster-management-io:main
Summary
fix: ManifestWorkReplicaSet applied capitalization error
Related issue(s)
Found this weird capitalization while working on open-cluster-management-io/ocm#1054
Summary by CodeRabbit
Refactor
Bug Fixes
Impact