Skip to content

Conversation

@NeKo2903
Copy link
Contributor

No description provided.

@slayoo slayoo changed the title Update setup.py PySDM logo Sep 1, 2024
@slayoo
Copy link
Member

slayoo commented Sep 1, 2024

@NeKo2903, thank you!
Let's add it also to the pdoc template (as here: open-atmos/PyMPDATA@af28fec#diff-f6dde991010615342868cc3970e6997188c3ee821f203d3b4096c0d08e53f6ef)

@slayoo slayoo mentioned this pull request Sep 1, 2024
@slayoo
Copy link
Member

slayoo commented Sep 1, 2024

The NumPy deprecation warning is being addressed in #1383

@slayoo slayoo marked this pull request as ready for review September 1, 2024 11:07
README.md Outdated
@@ -1,3 +1,5 @@
# <img src="https://raw.githubusercontent.com/open-atmos/PySDM/main/.github/pysdm_logo.svg" style="height:50pt" alt="pysdm logo">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the png logo is 100x146, hence this will result in blurry image on PyPI, let's change to width=100 height=146?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 66e08d6

@codecov
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (5bf30f9) to head (66e08d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1381   +/-   ##
=======================================
  Coverage   84.30%   84.30%           
=======================================
  Files         373      373           
  Lines        9160     9160           
=======================================
  Hits         7722     7722           
  Misses       1438     1438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo slayoo merged commit ec1f515 into open-atmos:main Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants