Skip to content

Conversation

@slayoo
Copy link
Member

@slayoo slayoo commented Jul 24, 2024

No description provided.

slayoo added 2 commits July 22, 2024 17:46
…le: bulk phase partitioning with one impl as in Kaul et al. 2015; raising exceptions for typo-rich constants overrides
@slayoo
Copy link
Member Author

slayoo commented Jul 24, 2024

CC: @trontrytel, @AgnieszkaMakulska, @tluettm, @amylu00

Here's a first step towards implementing a new mixed-phase example in PySDM: the Abade & Albuquerque 2024 study (https://doi.org/10.1002/qj.4775)

For now, we have Fig. 2c reproduced:
image

Next steps:

  • immersion freezing (straightforward, can use existing INAS logic in PySDM, can be extended to compare with time-dependent ABIFM)
  • diffusional growth - will need extension of existing liquid condensation support to cover ice phase
  • the fluctuations model following the paper (incl. local temperature and local vapour mixing ratio attributes)

Feedback and contributions welcome!

@codecov
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.12%. Comparing base (267eef7) to head (ee662e1).

Files Patch % Lines
...physics/bulk_phase_partitioning/kaul_et_al_2015.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
+ Coverage   84.09%   84.12%   +0.02%     
==========================================
  Files         366      368       +2     
  Lines        9006     9024      +18     
==========================================
+ Hits         7574     7591      +17     
- Misses       1432     1433       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo slayoo merged commit 324fc29 into open-atmos:main Jul 25, 2024
@trontrytel
Copy link
Contributor

This looks great! Thank you for letting us know. It will be great to use it for testing/calibration of the bulks scheme ice formation in CM.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants