Skip to content

Conversation

@ksc-odoo
Copy link
Contributor

No description provided.

@ksc-odoo ksc-odoo added this to the 14.0 milestone Mar 22, 2021
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain why you are removing those docs?

Tip: once one of your [REM] PRs is approved, you can simply copy-paste the commit message in every other similar commit.

Also, same as for #909 and #910, could you take the opportunity to clear the end of ecommerce/maximizing_revenue.rst to only leave one empty line?

@ksc-odoo ksc-odoo force-pushed the 14.0-ecommerce-crosssell-upsell-promo-deletion-ksc branch from 5ef1a0a to cf4f0b0 Compare March 31, 2021 22:35
@ksc-odoo ksc-odoo requested a review from AntoineVDV March 31, 2021 22:35
@AntoineVDV AntoineVDV removed their request for review April 1, 2021 07:21
Remove unnecessary, straightforward, easy-to-figure out documentation, as part of an effort to clear
out any sort of documentation that is either too easy, too simple,
or already gone over in the tutorial videos. This documentation falls into that category. Hence,
it was removed entirely. Closed PR921 and merged changes with this (PR 911).
@ksc-odoo ksc-odoo force-pushed the 14.0-ecommerce-crosssell-upsell-promo-deletion-ksc branch from cf4f0b0 to 9b49037 Compare April 5, 2021 18:56
@ksc-odoo ksc-odoo changed the title [REM] ecommerce: removed upsell, cross-sell, and promo code [REM] ecommerce: removed upsell, cross-sell, promo code, and reviews Apr 5, 2021
@ksc-odoo ksc-odoo requested a review from AntoineVDV April 5, 2021 18:57
@AntoineVDV AntoineVDV removed their request for review April 6, 2021 08:10
@ksc-odoo ksc-odoo closed this Apr 7, 2021
@ksc-odoo ksc-odoo deleted the 14.0-ecommerce-crosssell-upsell-promo-deletion-ksc branch April 7, 2021 19:57
@samueljlieber samueljlieber added the cancelled Designation for PRs that are cancelled and closed, the PR should include a closing comment label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cancelled Designation for PRs that are cancelled and closed, the PR should include a closing comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants