Skip to content

[ADD] product_images: add a tutorial to get automatically images for products #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Fix a typo: user menu registry example
wants to merge 1 commit into from
Closed

[ADD] product_images: add a tutorial to get automatically images for products #1007

wants to merge 1 commit into from

Conversation

@chevalierv
Copy link
Contributor

@chevalierv chevalierv commented Jun 1, 2021 •
edited
Loading

This will help users to get automatically images for their products.

task-2558054

@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from a9168ce to bcafe81 Compare June 1, 2021 10:23
@chevalierv chevalierv requested a review from AntoineVDV June 1, 2021 10:24
@AntoineVDV AntoineVDV removed their request for review June 2, 2021 12:45
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from bcafe81 to dc7402e Compare June 29, 2021 15:39
@Feyensv Feyensv added this to the 15.0 milestone Jun 30, 2021
@AntoineVDV AntoineVDV marked this pull request as ready for review July 1, 2021 10:44
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from d5346c9 to 0c97f3c Compare July 1, 2021 12:46
@chevalierv chevalierv changed the title [ADD] product_images: basic documentation to generate the credentials [ADD] product_images: add a tutorial to get automatically images for products Jul 1, 2021
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from 0c97f3c to e22930f Compare July 8, 2021 08:32
@AntoineVDV AntoineVDV force-pushed the master-get_product_image_using_barcode-vcr branch from e22930f to 65e39bd Compare July 28, 2021 09:37
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from 65e39bd to 4d0ad40 Compare September 29, 2021 10:10
@chevalierv chevalierv requested a review from a team as a code owner September 29, 2021 10:10
@robodoo
Copy link
Collaborator

robodoo commented Sep 29, 2021

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

@robodoo
Copy link
Collaborator

robodoo commented Sep 29, 2021

Pull request status dashboard.

@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from 4d0ad40 to 7f8cff7 Compare September 29, 2021 10:17
@Feyensv Feyensv removed the request for review from a team September 29, 2021 10:18
pierre-pde
pierre-pde reviewed Oct 1, 2021
View reviewed changes
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from 7f8cff7 to da2de01 Compare October 4, 2021 10:21
@chevalierv chevalierv requested a review from jubodoo October 29, 2021 09:31
@jubodoo
Copy link
Contributor

jubodoo commented Nov 8, 2021

@AntoineVDV Content wise it was okay. I'm good with it.

Feyensv
Feyensv reviewed Nov 8, 2021
View reviewed changes
Copy link
Collaborator

@Feyensv Feyensv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say 👀

I'm hesitating if this is the correct place to put this document (or in Sales/Products & Price) but I'm not sure, so keep it there for the moment ^^.

Note: rebased and retargeted to 15.0 to have latest fixes for runbot builds.

@Feyensv Feyensv changed the base branch from master to 15.0 November 8, 2021 12:21
@Feyensv Feyensv force-pushed the master-get_product_image_using_barcode-vcr branch from da2de01 to f340a29 Compare November 8, 2021 12:22
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch 2 times, most recently from 5636f0b to dbb00e3 Compare November 8, 2021 15:16
AntoineVDV
AntoineVDV requested changes Nov 8, 2021
View reviewed changes
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch 2 times, most recently from e9da4bd to c9a48cd Compare November 9, 2021 11:02
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from c9a48cd to 917ca7e Compare November 9, 2021 11:02
jcs-odoo
jcs-odoo reviewed Nov 10, 2021
View reviewed changes
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

since @AntoineVDV requested my opinion on two specific points, here are my comments :) But it isn't a detailed review of the doc, as I haven't properly read it. I merely added two suggestions (typo + group the notes) for the things that I saw while skim-reading the doc.

Cheers :)

@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch 6 times, most recently from 7792633 to 56e7477 Compare November 15, 2021 13:38
AntoineVDV
AntoineVDV requested changes Nov 15, 2021
View reviewed changes
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from 56e7477 to 3909194 Compare November 15, 2021 14:48
AntoineVDV
AntoineVDV approved these changes Nov 15, 2021
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

@AntoineVDV
Copy link
Collaborator

@robodoo r-

missing redirects

@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch 2 times, most recently from 3378fe9 to da2ff45 Compare November 15, 2021 15:04
AntoineVDV
AntoineVDV requested changes Nov 15, 2021
View reviewed changes
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from da2ff45 to 39ea997 Compare November 15, 2021 15:11
@chevalierv
[ADD] product_images: add a tutorial
fac0b64 
This will help users to get automatically images for their products.

task-2558054
@chevalierv chevalierv force-pushed the master-get_product_image_using_barcode-vcr branch from 39ea997 to fac0b64 Compare November 15, 2021 15:12
@AntoineVDV
Copy link
Collaborator

@robodoo r+

@robodoo robodoo closed this in e062a7c Nov 15, 2021
@fw-bot fw-bot mentioned this pull request Nov 15, 2021
Closed
@robodoo robodoo temporarily deployed to merge November 15, 2021 15:22 Inactive
@fw-bot fw-bot deleted the master-get_product_image_using_barcode-vcr branch November 29, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Feyensv Feyensv Feyensv left review comments

@jcs-odoo jcs-odoo jcs-odoo left review comments

@AntoineVDV AntoineVDV AntoineVDV requested changes

@jubodoo jubodoo jubodoo approved these changes

+1 more reviewer

@pierre-pde pierre-pde pierre-pde left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.

7 participants

@chevalierv @robodoo @jubodoo @AntoineVDV @Feyensv @jcs-odoo @pierre-pde