This repository was archived by the owner on Dec 22, 2020. It is now read-only.
Fix for turkish locale bug #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While in turkish locale, transforming string with letters 'I' and 'i' to lowercase/uppercase cause these letters to be transofrmed into İ and ı respectively, which are not I nor i, notice the difference. This causes an exception in obtaining query type, as ınsert != insert.
Member
|
Thanks @kakysha for this improvement but as you know the native part of this plugin comes from cordova-sqlite-storage and since I am not confortable with that part (here I coded only the JavaScript wrapper) I want to stick to the original code. I saw that you had also submitted a pull request in cordova-sqlite-storage's repository, so I will wait for this pull request to be merged and then I will update my repository with the latest version of cordova-sqlite-storage. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While in turkish locale, transforming string with letters 'I' and 'i' to lowercase/uppercase cause these letters to be transofrmed into İ and ı respectively, which are not I nor i, notice the difference. This causes an exception in obtaining query type, as ınsert != insert.