This repository was archived by the owner on Feb 19, 2023. It is now read-only.
Fix fake output on std_error #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Any chance this is useful, or should I just delete this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should filter out the "fake" errors that neuron prints that are actually debug/info logs. I also re-enabled the error logging in the one place it had been disabled. I tried to think of a more generic way to filter them (maybe check for color?) but a map of fake errors was the best I could come up with.
Fixes #44 which was related to this. I think the error logging had been disabled in
new_editbut not innew_and_callback. So, if you tried to make a new zettel by using thefind_zettelscommand, you would see errors even though everything worked properly.