fix: recommended setting for redis when using 1 replica #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use only 1 replicas, we need to update the redis configuration min-replicas-to-write to 0 otherwise we have the error message "NOREPLICAS Not enough good replicas to write". Ref: https://stackoverflow.com/a/59737862
nleconte-csgroup
changed the title
tuunit
reviewed
Sep 30, 2025
| # https://artifacthub.io/packages/helm/dandydev-charts/redis-ha#general-parameters | ||
| # | ||
| # Recommended: | ||
| # |
There was a problem hiding this comment.
I think we should take the opportunity and change this section a bit more. Instead of having a single node cluster setup as the recommendation. We should reference the example files directory here. What do you think?
There was a problem hiding this comment.
@pierluigilenoci whats your stance on this?
There was a problem hiding this comment.
Anything that improves the readability or usefulness of the value file is welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
To use only 1 replicas, we need to update the redis configuration
min-replicas-to-writeto 0 otherwise we have the error message "NOREPLICAS Not enough good replicas to write".Ref: https://stackoverflow.com/a/59737862
Note: It's well configured in the CI :
manifests/helm/oauth2-proxy/ci/redis-standalone-values.yaml
Line 29 in 3832a76
It's just missing in the doc