Skip to content

Conversation

@aaronpk
Copy link
Member

@aaronpk aaronpk commented Oct 17, 2025

just thought this reads better

@aaronpk aaronpk requested a review from tlodderstedt as a code owner October 17, 2025 23:36
@aaronpk aaronpk merged commit a6c668c into main Oct 17, 2025
2 checks passed
@aaronpk aaronpk deleted the aaronpk/editorial branch October 17, 2025 23:41
("Private Key JWT") in accordance with {{RFC7521}}, {{RFC7523}},
and their update {{I-D.ietf-oauth-rfc7523bis}}
(in {{OpenID}} defined as the client authentication method `private_key_jwt`).
(defined in {{OpenID}} as the client authentication method `private_key_jwt`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strongly speaking, it's defined in OpenID Connect... isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in this doc {{OpenID}} is a shorthand reference to OpenID Connect. It should link up correctly to the references if you click through in the HTML version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't what I saw... and that's why I left a comment about this minor nit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets rendered as "OpenID" in txt and html formats like

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and if you click it it goes to the link at the bottom that says OpenID Connect. Do you think the short name should be updated throughout? That wasn't a change made in this PR. You are welcome to send a new PR that updates the short name everywhere in the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants