Skip to content

temporaly force validators to enable vote to activate fast finality #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2024
Merged

temporaly force validators to enable vote to activate fast finality #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d91791
temporaly force validators to enable vote to activate fast finality
tak1827 Nov 26, 2024
3e6b5ad
remove voting as keyword to avoid confusion
tak1827 Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions eth/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,13 @@ func (s *Ethereum) StartMining() error {
return fmt.Errorf("signer missing: %v", err)
}
oas.Authorize(eb, wallet.SignData, wallet.SignTx)

// Temporarily force miners to enable voting to prompt validators to encourage validators to register voting keys
if !s.config.Miner.VoteEnable {
err := errors.New("vote is not enabled, please enable vote")
techDocRef := "https://docs.oasys.games/docs/hub-validator/operate-validator/build-validator-node#enabling-fast-finality"
return fmt.Errorf("temporarily force validators to enable voting. Please proceed with registering your BLS key. For more details, refer to the technical documentation: %s, err: %v", techDocRef, err)
}
}
// If mining is started, we can disable the transaction rejection mechanism
// introduced to speed sync times.
Expand Down