Skip to content

Conversation

@Trivo25
Copy link
Member

@Trivo25 Trivo25 commented Oct 30, 2025

@Trivo25 Trivo25 requested review from a team as code owners October 30, 2025 14:18
@Trivo25 Trivo25 changed the base branch from main to native/napi October 30, 2025 14:48
@bleepbloopsify
Copy link
Contributor

bleepbloopsify commented Oct 30, 2025

I think you might need to git reset origin/native/napi before these changes, because the build script has changed a little bit

otherwise looks fine to me

Copy link
Member

@querolita querolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still shows a wrong commit history due to the force pushing some weeks ago, we might have to solve conflicts on the build side when we merge. Maybe we should rebase before doing it to reduce the number of commits in the diff.

@querolita querolita force-pushed the florian/verifier-index-napi branch from f75a676 to 896940c Compare November 3, 2025 18:25
@querolita querolita force-pushed the florian/verifier-index-napi branch from 30f0544 to 013f36a Compare November 4, 2025 16:02
@querolita querolita merged commit a891024 into native/napi Nov 4, 2025
1 of 3 checks passed
@querolita querolita deleted the florian/verifier-index-napi branch November 4, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants