Skip to content

Fixed typo in p2p_request_transactions_if_needed #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Fixed typo in p2p_request_transactions_if_needed #1563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
See issue [#1464](https://github.com/o1-labs/mina-rust/issues/1464).
Fixed in [#1546](https://github.com/o1-labs/mina-rust/pull/1546/)
([#1546](https://github.com/o1-labs/mina-rust/pull/1546))
- **transactions**: fixed a typo in `p2p_request_transactions_if_needed` where snark count was used instead of transaction count
([#1563](https://github.com/o1-labs/mina-rust/pull/1563)).

## v0.17.0

Expand Down
5 changes: 4 additions & 1 deletion node/src/effects.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,10 @@ fn p2p_request_transactions_if_needed<S: Service>(store: &mut Store<S>) {
.ready_peers_iter()
.filter(|(_, p)| p.channels.transaction.can_send_request())
.map(|(peer_id, _)| {
let pending_txs = state.snark_pool.candidates.peer_work_count(peer_id);
let pending_txs = state
.transaction_pool
.candidates
.peer_transaction_count(peer_id);
(peer_id, MAX_PEER_PENDING_TXS.saturating_sub(pending_txs))
})
.filter(|(_, limit)| *limit > 0)
Expand Down
Loading