Skip to content

Rename openmina to mina #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 21, 2025
Merged

Rename openmina to mina #1314

merged 6 commits into from
Aug 21, 2025

Conversation

@dannywillems
Copy link
Member

@dannywillems dannywillems commented Aug 14, 2025 •
edited
Loading

Fix #1313

@dannywillems dannywillems force-pushed the rename-openmina-to-mina branch 2 times, most recently from 0eac3db to d3283ae Compare August 18, 2025 08:21
@dannywillems dannywillems moved this to In Progress in Rust node Aug 18, 2025
@dannywillems dannywillems requested a review from 0xMimir August 18, 2025 09:49
@dannywillems dannywillems marked this pull request as draft August 18, 2025 09:49
@dannywillems dannywillems requested a review from volhovm August 18, 2025 09:49
@dannywillems dannywillems force-pushed the rename-openmina-to-mina branch 3 times, most recently from f5655b2 to d221fd3 Compare August 20, 2025 10:47
@dannywillems dannywillems force-pushed the rename-openmina-to-mina branch 4 times, most recently from 2441144 to 3392ca0 Compare August 21, 2025 09:37
@dannywillems dannywillems force-pushed the rename-openmina-to-mina branch from 3392ca0 to 31cf5e9 Compare August 21, 2025 09:49
@dannywillems dannywillems marked this pull request as ready for review August 21, 2025 13:45
@directcuteo directcuteo force-pushed the rename-openmina-to-mina branch from 9816c5a to 40dadd6 Compare August 21, 2025 14:01
@dannywillems
CI/docker: remove path dependency for docker jobs
6c90910
@dannywillems
CI: increase p2p-tests timeout to 15
ac185d6 
It took once longer than 10 minutes, for no reason, therefore increasing
@dannywillems dannywillems enabled auto-merge August 21, 2025 15:03
@dannywillems dannywillems requested a review from yamimaio August 21, 2025 15:04
@dannywillems
Copy link
Member Author

dannywillems commented Aug 21, 2025

The expected jobs, waiting for status, is because we changed the name to, for instance:

[Mina Docker Build / build-mina-node-image (linux/amd64, ubuntu-latest) (push)](https://github.com/o1-labs/mina-rust/actions/runs/17130870814/job/48594517212?pr=1314)

yamimaio
yamimaio approved these changes Aug 21, 2025
View reviewed changes
Copy link
Collaborator

@yamimaio yamimaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checkout the branch and looked for openmina. I have aprox 1295 occurances.
Most are urls, images paths (both literal images and docker images) and a bunch for frontend elements.

Most notably I found
Screenshot 2025-08-21 at 5 42 01 PM
Screenshot 2025-08-21 at 5 42 21 PM
Screenshot 2025-08-21 at 5 45 07 PM
Screenshot 2025-08-21 at 5 45 15 PM

However, as we agreed, I'm not blocking you

@dannywillems dannywillems disabled auto-merge August 21, 2025 22:00
@dannywillems dannywillems merged commit 755bc86 into develop Aug 21, 2025
134 of 137 checks passed
@dannywillems dannywillems moved this from In Progress to Done in Rust node Aug 25, 2025
@dannywillems dannywillems self-assigned this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xMimir 0xMimir 0xMimir left review comments

@yamimaio yamimaio yamimaio approved these changes

@volhovm volhovm Awaiting requested review from volhovm

Assignees

@dannywillems dannywillems

Labels

test-doc-scripts

Projects

Rust node
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename OpenMina to "Rust node" and rename openmina to mina in the codebase

5 participants

@dannywillems @yamimaio @0xMimir @directcuteo