Docker: fix openmina dockerfile and slightly improve it #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
commented
Jul 16, 2025
|
|
||
| COPY . . | ||
| # Build with cache mount | ||
| RUN --mount=type=cache,target=/usr/local/cargo/registry \ |
There was a problem hiding this comment.
docker build -t openmina/openmina:6945ec6b .
[+] Building 399.3s (21/21) FINISHED
I guess it is fine for now.
There was a problem hiding this comment.
dannywillems
force-pushed
the
dw/fix-docker-openmina
branch
from
2358b91 to
2866dc4
Compare
dannywillems
force-pushed
the
dw/fix-docker-openmina
branch
from
80dcc04 to
98920c2
Compare
dannywillems
force-pushed
the
dw/add-hadolint
branch
from
8209382 to
a0221d1
Compare
dannywillems
force-pushed
the
dw/fix-docker-openmina
branch
from
98920c2 to
b1a8e9e
Compare
dannywillems
force-pushed
the
dw/fix-docker-openmina
branch
from
b1a8e9e to
191ed99
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always build the docker images in CI, but do not publish it except on main, develop or a tag, as before.